Process - Interview Questions and Answers for 'Code Review' | Search Interview Question

Process - Interview Questions and Answers for 'Code Review' - 8 question(s) found - Order By Newest

Q1. What do you look for when you do code review ?

Ans. Modularity - First sign of good code is whether it has been segregated into methods and classes appropriately. I dont mind it in excess because I believe that is forward looking strategy as applications tends to expand and eventually become hard to read.

Self Explanatory - Variables and methods should be named in a way that the code should be self explanatory even without comments. Use of Constant variables to explain use of literal.

Proper Code Reuse - If there is anything being reused , it should be moved to parent classes / methods.

Proper composition calls - Composed hierarchy should not be access in just single line. One or two levels is ok but having multiple levels make it hard to read and debug.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve code review clean code Asked in 1 Companies intermediate frequent}

Q2. Should good code be self-documenting, or is it the responsibility of the developer to document it?

Process

Ans. Open ended Questions.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve java open questions code review documentation clean code}

Q3. Do you know the way to remove unused imports automatically in eclipse ?

Eclipse

Ans. Select the package -> Right Click -> Source -> Organize Imports.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve eclipse import statement code cleaning code review clean code}

Q4. What is the difference between Fisheye and Crucible ?

Ans. FishEye is used to extract information from source code repository whereas Crucible is used to request, perform and manage code reviews.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve java fisheye crucible code review tools}

Q5. Can we use Fisheye and Crucible independently ?

Ans. Yes

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve java fisheye crucible code review tools yes-no}

Q6. What does the red and green line backgrounds denotes in the crucible code Review ?

Ans. Red Background for a line denotes the lines that have been deleted with the change set and Green background denotes the addition.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve java crucible fisheye code review}

Q7. If a team member send you the code for review which you don't agree to but is just slightly off , Would you approve it or reject it ?

General

^{This question was recently asked at 'Sofi'.This question is still unanswered. Can you please provide an answer.}

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve code review Asked in 1 Companies}

Q8. Give an example of a time when you recommended code changes in a code review that simplified the code ?

Code Review

Ans. If there is a situation to remove duplicates values from an arrayList. Developer implemented using legacy for-loop where I suggested to use Linked hash set to remove duplicates from the list.

Help us improve. Please let us know the company, where you were asked this question :

_{Like Discuss Correct / Improve Clean code Asked in 3 Companies}

Search Interview Questions

Help us and Others Improve. Please let us know the questions asked in any of your previous interview.